-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split APIv3 tests on different files #5911
Conversation
readthedocs/api/v3/tests/mixins.py
Outdated
users=[], | ||
versions=[], | ||
) | ||
# self.translation = fixture.get(Project, slug='translation') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did a quick review, looks good
readthedocs/api/v3/tests/mixins.py
Outdated
# self.translation = fixture.get(Project, slug='translation') | ||
|
||
self.project.add_subproject(self.subproject) | ||
# self.project.add_translation(self.translation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this one
readthedocs/api/v3/tests/mixins.py
Outdated
project=self.project, | ||
active=True, | ||
built=True, | ||
type='tag', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to get this from the readthedocs/projects/constants.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or builds/constants.py
can't remember the exact file
'projects-versions-list', | ||
kwargs={ | ||
'parent_lookup_project__slug': self.others_project.slug, | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't match the indentation
…riables APIv3 endpoint to manage Environment Variables
…/apiv3-split-tests
Just a refactor to easily find the right test easily now that they are growing.